- 
                Notifications
    You must be signed in to change notification settings 
- Fork 186
          fix: return str instead of urllib3.HTTPResponse for `InfluxDBClie…
          #606
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6ae3a67    to
    0a4ae41      
    Compare
  
    | 
 Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   90.30%   90.11%   -0.20%     
==========================================
  Files          39       39              
  Lines        3456     3430      -26     
==========================================
- Hits         3121     3091      -30     
- Misses        335      339       +4     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| I had to use  | 
| Ready for review | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jules-ch,
Thank you for your PR. Could you please update the CHANGELOG.md to indicate that this is a breaking change and provide guidance on how users should address it?
Thanks!
| Do you need me to introduce this as a BREAKING CHANGE. I'll document it as a Breaking change for now | 
f024155    to
    cb5ff71      
    Compare
  
    …nt.QueryAPI.query_raw`
cb5ff71    to
    f0c7ef4      
    Compare
  
    | CI is failing because of a problem on CircleCI I think. Pipeline needs to be triggered again. | 
Closes #569
Proposed Changes
As it is done in the Async version of the client, return
strresponse data as per the documentation.Checklist
pytest testscompletes successfully