Update graph names to be camelCase to follow graphql best practices #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
Member
Author
|
The Apollo schema check fails because this introduces a breaking change. This is a new API so we should discuss if we want to do this as a breaking change or have backwards compatibility to start with. |
sfunkhouser
approved these changes
Jul 19, 2023
Contributor
|
Need to update the ipam client as well. I could do that in a follow-up PR |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best practices for graphql recommend using camelCase not snake_case. More details on these can be seen here: https://www.apollographql.com/docs/technotes/TN0002-schema-naming-conventions/