[UPD] base_bg: Update error handling to accept string type and improve timeout notification #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@roboadhoc r+ |
|
@joa-adhoc @lav-adhoc 'ci/runbot-modified-modules' failed on this reviewed PR. |
There was a problem hiding this comment.
Pull request overview
Este PR actualiza el manejo de errores en jobs en segundo plano para aceptar strings además de excepciones, y mejora la notificación de timeouts mediante el uso de _handle_job_error.
- Ampliación de la firma de
_handle_job_errorpara aceptarException | str - Refactorización en
_cron_check_running_jobspara usar_handle_job_errory agregar verificación de estado antes de notificar
joa-adhoc
force-pushed
the
19.0-t-62057-joa-2
branch
from
b15aca5 to
bc5e90d
Compare
…e timeout notification
joa-adhoc
force-pushed
the
19.0-t-62057-joa-2
branch
from
bc5e90d to
4a28726
Compare
Contributor
|
@roboadhoc r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.