[FIX] ir_actions_report: Fix parameter in _get_rendering_context method #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull request overview
Este PR corrige la firma del método _get_rendering_context en el modelo ir.actions.report para alinearse con la API de Odoo 19, agregando el parámetro report que faltaba.
- Se actualiza la firma del método
_get_rendering_contextpara incluir el parámetroreport - Se pasa el parámetro
reporta la llamadasuper()para mantener compatibilidad con la clase padre
| res = super()._get_rendering_context(docids, data) | ||
| def _get_rendering_context(self, report, docids, data): | ||
| res = super()._get_rendering_context(report, docids, data) | ||
| ncopies = self.ncopies |
There was a problem hiding this comment.
Con el decorador @api.model, el uso de self.ncopies es incorrecto ya que self representa la clase del modelo, no una instancia de registro. Ahora que el parámetro report está disponible (que es el registro de ir.actions.report), debe usarse report.ncopies en lugar de self.ncopies para acceder al campo correctamente.
Suggested change
| ncopies = self.ncopies | |
| ncopies = report.ncopies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.