fix: move block env creation for host to env task #169
+114
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
changed the title
anna-carroll
approved these changes
Nov 7, 2025
Contributor
anna-carroll
left a comment
anna-carroll
left a comment
There was a problem hiding this comment.
only naming and comments thoughts
Evalir
approved these changes
Nov 7, 2025
dylanlott
force-pushed
the
prestwich/env-env-env-env
branch
from
1d01ce0 to
31344da
Compare
Contributor
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anna-carroll
reviewed
Nov 7, 2025
| HostEnv<HostAlloyDatabaseProvider, NoOpInspector>, | ||
| ) { | ||
| // Host DB and Env | ||
| let host_block_number = BlockNumber::from(sim_env.prev_host.number); |
Contributor
There was a problem hiding this comment.
this is where the bug was. need to add 1 to the prev host header's block number
anna-carroll
reviewed
Nov 7, 2025
| BlockEnv { | ||
| fn construct_block_env(&self, previous: Header) -> Environment { | ||
| let env = BlockEnv { | ||
| number: U256::from(previous.number + 1), |
Contributor
There was a problem hiding this comment.
you can see here, the rollup block env was being created by adding 1 to the previous header's number. by refactoring to move the host block env creation to use the same function, we fix the bug
dylanlott
approved these changes
Nov 7, 2025
Contributor
|
Approved, we can merge this stack down into main and test for final release. |
dylanlott
pushed a commit
that referenced
this pull request
Nov 7, 2025
* fix: move block env creation for host to sim task * rename vars to clearly distinguish between rollup and host (#170) * comment --------- Co-authored-by: Anna Carroll <anna-carroll@users.noreply.github.com> Co-authored-by: Anna Carroll <anna.s.carroll@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.