feat: simplify configuration of Signed Orders and Fills before signing #140
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
requested changes
Nov 11, 2025
Member
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
can we do this as semver minor instead of semver major?
- don't change the error type
- don't change the fn names
- don't delete the unused function, add a
#[deprecated()]tag instead
anna-carroll
force-pushed
the
anna/with-constants
branch
from
23c0e53 to
5926a2c
Compare
Contributor
Author
|
revm build is what's breaking CI |
Evalir
approved these changes
Nov 11, 2025
prestwich
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.