Skip to content

chore: fix unit tests for python 3.13, pin pandas < 3#64

Merged
nosheen-adil merged 2 commits intomainfrom
fix-python313-tests
Feb 5, 2026
Merged

chore: fix unit tests for python 3.13, pin pandas < 3#64
nosheen-adil merged 2 commits intomainfrom
fix-python313-tests

Conversation

@nosheen-adil
Copy link
Copy Markdown
Contributor

@nosheen-adil nosheen-adil commented Feb 2, 2026

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Fix unit tests for python 3.13 by pinning pandas version < 3.

Additionally, stop testing on python 3.9, since this version stopped working on the windows server, and we are planning to deprecate support for this version since it's reached EOL.

Testing Instructions

make clean
make env PYTHON=python3.13
THIRD_PARTY_DIR=$(pwd)/../mosaic2/third_party make build
THIRD_PARTY_DIR=$(pwd)/../mosaic2/third_party TEST_DATA_DIR=$(pwd)/../mosaic2/test_data make test

Alternatively, if you can't build the wheel file, here's one already built: https://bruker-my.sharepoint.com/:u:/p/nosheen_adil/IQDMEm5gCl-vSbCjZhv6q6NAAWDD2Ptt_yZnaq7wVbuh-E4?email=Brandon.Cazander%40bruker.com&e=UyeCCM

python3.13 -m venv venv
source venv/bin/activate
pip install isx-2.1.0-cp313-cp313-manylinux_2_34_x86_64.whl
python -c "import isx"

Added/updated tests?

  • Yes
  • No, and this is why: Only need to validate existing behavior.
  • I need help with writing tests

@nosheen-adil nosheen-adil requested a review from a team as a code owner February 2, 2026 20:00
@nosheen-adil nosheen-adil merged commit 3ac1c50 into main Feb 5, 2026
5 of 6 checks passed
@nosheen-adil nosheen-adil deleted the fix-python313-tests branch February 5, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants