refactor: filter node internal and instana instrumentation traces from span stack trace #2162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will optionally add prettify functionality later, which is specified in the technical specification. Not important right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs INSTA-63749
This PR introduces a filter in the current implementation to remove Node.js internal frames and Instana instrumentation frames from span stack traces. This is needed as part of the refactoring of our stack-generation logic.
Right now, the stack_trace is generated before instrumentation, which correctly captures only the customer application flow. However, after moving stack generation to occur after instrumentation — especially in certain error scenarios and once monkey-patching begins — the stack trace starts including internal instrumentation calls. As a result, we lose the relevant application information. This PR ensures we continue to capture only the meaningful stack frames