Skip to content

Conversation

@suhaibabsi-inst
Copy link
Contributor

refs: MBL-19572
affects: Student
builds: Student
release note: Fixed issue of students were unable to view their un-graded submission when restrict quantitative data is enabled

Test Plan

See ticket's description for steps to reproduce.
Also, a regression test is made to check other cases with restrict_quantitative_data ON & OFF:
graded, submitted, un-submitted

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

…itative data is enabled

refs: MBL-19572
affects: Student
builds: Student
release note: Fixed issue of students were unable to view their un-graded submission when restrict quantitative data is enabled
@suhaibabsi-inst suhaibabsi-inst self-assigned this Dec 17, 2025
@claude
Copy link

claude bot commented Dec 17, 2025

Claude Code Review

Updated: 2025-12-17

Issues Found

Critical Bugs:

  • Logic Error in isBlankGrade (line 501): Returns String value (self) instead of Bool. Should return the boolean result of the isEmpty check.
  • Type Mismatch: Extension returns String instead of Bool - causes compilation failure explaining DangerJS build failure.
  • Build Status: Code will not compile with current implementation.

Required: Fix line 501 to properly return boolean value from isBlankGrade computed property.

Issues found

@inst-danger
Copy link
Contributor

inst-danger commented Dec 17, 2025

Warnings
⚠️ One or more files are below the minimum test coverage 50%

Release Note:

Fixed issue of students were unable to view their un-graded submission when restrict quantitative data is enabled

Affected Apps: Student

Builds: Student

MBL-19572

Coverage New % Master % Delta
Canvas iOS 91.1% 81.06% 10.04%
Horizon/Horizon/Sources/Common/View/CourseDetailsAccessibility.swift 0% -- --

Generated by 🚫 dangerJS against fa05fb9

@inst-danger
Copy link
Contributor

inst-danger commented Dec 17, 2025

Builds

Commit: Merge branch 'master' into bugfix/MBL-19572-Student-CantView-Submission-When-RestrictQuantitiveData-IsOn (fa05fb9)
Build Number: 1046
Built At: Dec 21 11:33 CET (12/21 03:33 AM MST)

Student

@suhaibabsi-inst suhaibabsi-inst marked this pull request as ready for review December 17, 2025 15:23
@rh12 rh12 requested a review from petkybenedek December 18, 2025 15:13
Copy link
Contributor

@petkybenedek petkybenedek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1, besides the suggestion
iOS 26, iPhone 15

Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants