Skip to content

alyxclient is compatible with openapiv3#226

Merged
oliche merged 18 commits intov3.4.0from
openapi
Sep 25, 2025
Merged

alyxclient is compatible with openapiv3#226
oliche merged 18 commits intov3.4.0from
openapi

Conversation

@oliche
Copy link
Member

@oliche oliche commented Sep 12, 2025

@oliche oliche requested a review from k1o0 September 12, 2025 15:51
Copy link
Collaborator

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation needs updating as the list_endpoints and print_endpoint_info methods have been removed from AlyxClient. They're referenced in this notebook and possibly others: https://github.com/int-brain-lab/ONE/blob/main/docs/notebooks/useful_alyx_queries.ipynb

It also appears as though the coverage has decreased. Also please refrain from using ruff format for the time being as it makes reviewing the code quite difficult

@oliche
Copy link
Member Author

oliche commented Sep 15, 2025

The documentation needs updating as the list_endpoints and print_endpoint_info methods have been removed from AlyxClient. They're referenced in this notebook and possibly others: https://github.com/int-brain-lab/ONE/blob/main/docs/notebooks/useful_alyx_queries.ipynb

I suggest to add them back then. I'll push an atomic commit doing this and another one fixing the coverage (duh), and you can let me know if you would rather update the docs instead

@oliche oliche closed this Sep 15, 2025
@oliche oliche reopened this Sep 15, 2025
@oliche oliche requested a review from k1o0 September 16, 2025 08:47
@oliche oliche closed this Sep 22, 2025
@oliche oliche reopened this Sep 22, 2025
@k1o0
Copy link
Collaborator

k1o0 commented Sep 25, 2025

Manually squashed into #227

@k1o0 k1o0 closed this Sep 25, 2025
@oliche oliche reopened this Sep 25, 2025
@oliche oliche changed the base branch from main to v3.4.0 September 25, 2025 11:29
@oliche oliche closed this Sep 25, 2025
@oliche oliche reopened this Sep 25, 2025
@oliche oliche merged commit 0304eb5 into v3.4.0 Sep 25, 2025
4 of 15 checks passed
@oliche oliche deleted the openapi branch September 25, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants