Open
Conversation
For signatures like "sensitive_data: sensitive data - eMail addresses" (sid:5 gid:138) squert was displaying the wrong description.
Owner
|
As I was looking at your patch I was thinking 'that won't even fire' but it turns out the the check that is done earlier in that function is wrong, my intent was to stay out of that for loop completely if the GID was > 100 but with the <= it will run at least once :/ I want to re-check why I didn't want to process these GIDs before merging. |
Author
|
:) looking at the code I thought the same thing, (that your intention was never to enter the loop). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For signatures like "sensitive_data: sensitive data - eMail addresses" (sid:5 gid:138) squert was displaying the wrong description.