vaapi_encode_h264: enable deblocking filter control in PPS RTMP#781
Open
milosz-intern wants to merge 1 commit intointel-media-ci:masterfrom
Open
Conversation
Author
|
@mkver @michaelni Could you please explain how I can expedite the process of merging changes into a common patch for FFmpeg? What does this procedure look like? |
Contributor
|
Send the patch v1 to the ffmpeg-devel mailing list, cc the maintainer of the code contained in the patch. Resolve comments, resend patch v2, and wait for the maintainer merges the commit into the mainline. The process is never quick due to FFmpeg's use of the old-school mailing list. See also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media Transcode Accelerator team noticed problem during streaming h264 it in real-time by nginx RTMP.
JIRA report:
[VCX-2012] [BM][AUX] Corruption on video when streaming it in realtime by nginx RTMP - VCX-2012
Test commands:
ffmpeg -hwaccel vaapi \ -re -init_hw_device vaapi=hw:/dev/dri/renderD128 \ -hwaccel_output_format vaapi \ -i /home/input \ -muxdelay 0 -muxpreload 0 -reset_timestamps 1 \ -compression_level 2 -profile:v high -c:v h264_vaapi -rc_mode CQP -qp 25 -vf scale_vaapi=w=3840:h=1714 -c:a aac -b:a 128k -f flv rtmp://localhost/live/2160p \ -compression_level 2 -profile:v high -c:v h264_vaapi -rc_mode CQP -qp 25 -vf scale_vaapi=w=2560:h=1440 -c:a aac -b:a 128k -f flv rtmp://localhost/live/1440p \ -compression_level 2 -profile:v high -c:v h264_vaapi -rc_mode CQP -qp 25 -vf scale_vaapi=w=1920:h=1080 -c:a aac -b:a 128k -f flv rtmp://localhost/live/1080p \ -compression_level 2 -profile:v high -c:v h264_vaapi -rc_mode CQP -qp 25 -vf scale_vaapi=w=1280:h=720 -c:a aac -b:a 128k -f flv rtmp://localhost/live/720p \ -compression_level 2 -profile:v high -c:v h264_vaapi -rc_mode CQP -qp 25 -vf scale_vaapi=w=640:h=480 -c:a aac -b:a 128k -f flv rtmp://localhost/live/480pThen you should be able to capture the video streams from the server
ffmpeg -i [http://[YOUR_IP]:8080/hls/2160p.m3u8|http://[your_ip]/hls/2160p.m3u8] -c copy -t 60 output_gnrd.mp4 ffmpeg -i [http://[YOUR_IP]:8080|http://[your_ip]/]/hls/2160p_sw.m3u8 -c copy -t 60 output_sw.mp4Or you can use the VLC player to watch the video as it is served as HLS stream.
Result image
