Potential fix for code scanning alert no. 56: Uncontrolled data used in path expression #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in path expression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/intel/AI-PC-Samples/security/code-scanning/56
To fix the issue, we need to ensure that any path constructed for accessing local files under the
datadirectory is validated such that it remains within thedatadirectory and cannot escape via.., absolute paths, or symlinks. The best approach is to join the base directory with the user-supplied path, normalize the result (withos.path.normpath), and then check that the resulting path starts with the intended base directory (data_dir). If the check fails, raise an error and do not proceed to read the file.Changes are needed only in the
load_documentfunction, specifically in the "else" block when loading from the local file system (lines 88-103). No other logic or functionality needs to change. No external packages are required for this mitigation.Suggested fixes powered by Copilot Autofix. Review carefully before merging.