This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Open
Conversation
JeevakaPrabu
suggested changes
Mar 26, 2020
| public void openBackCamera() { | ||
| closeCamera(); | ||
| GetCameraCnt(); | ||
| if(numOfCameras == 1) { |
| @@ -0,0 +1,40 @@ | |||
| package com.intel.multicamera; | |||
There was a problem hiding this comment.
- rename the file to MultiCamera or someother name.
- Add copyright and license header
| private static IntelCamera ic_instance = null; | ||
|
|
||
| IntelCamera() { | ||
| WhichCamera = 0; |
There was a problem hiding this comment.
use small letter for first character
| private void OpenOnlyBackCamera() { | ||
| frameView0.setVisibility(FrameLayout.VISIBLE); | ||
| FrameVisibility[0] = frameView0.getVisibility(); | ||
| if (mTopLeftCam == null) { |
There was a problem hiding this comment.
possible pointer derefenece in line no: 431
| } else { | ||
| mTopLeftCam_textureView.setSurfaceTextureListener(mTopLeftCam.textureListener); | ||
| } | ||
| if(numOfCameras > 1) |
| frameView0.setVisibility(View.GONE); | ||
| frameView1.setVisibility(FrameLayout.VISIBLE); | ||
| FrameVisibility[0] = frameView1.getVisibility(); | ||
| if (mTopRightCam == null) { |
There was a problem hiding this comment.
same here. possible null pointer deference in line no: 471
| super.onResume(); | ||
| Log.e(TAG, "onResume"); | ||
| IntelCamera ic_cam = IntelCamera.getInstance(); | ||
| if(ic_cam.getIsCameraOrSurveillance() == 1){ |
| hideCameraSwitchButton(); | ||
| } | ||
| else { | ||
| if(ic_cam.getWhichCamera() == 0) { |
| findViewById(R.id.imageView3).setVisibility(View.VISIBLE); | ||
|
|
||
| } | ||
| public void visibleCameraSwitchButton() { |
There was a problem hiding this comment.
introduce blank line between new functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.