pm: handle reset prep IRQ #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lifenggitacc @tmalhotr we have granted you maintainer's role, please accept, review the patch, and merge if review result is ok, thanks. |
lifenggitacc
previously approved these changes
Mar 21, 2025
ddeshat
force-pushed
the
is_pm_isr_enable
branch
from
5f4e582 to
6e6a91e
Compare
In the SoC warm reboot process, sometimes there are instances where the ISH firmware fails to receive the warm reboot request from PMC, leading to the failure to reboot ISH firmware hence causing ISHTP kernel driver communication failure with ISH firmware. This issue is observred when there is an IPC request pending at the ISH and at the time a warm reboot is initiated causing IPM driver timeout. The IPM driver timeout is set to 1sec waiting for the Peer ACK. Due to warm reboot, Peer ACK is not received leading to timeout of 1sec. During this time ISH HW triggeres the RESET PREP IRQ, but we do not observe ISR routine exexuted at firmware side which is expected to handle the warm reboot. Changes done to perform ish pm init using zephyr SYS_INIT() in PRE_KERNEL_2 stage. This change helps handle the IRQ rightly and invokes the ISR routine to handle the firmware reset. Change-Id: I454bd75257cdfc1c8f37e582231f6fe7f5e8f91d
ddeshat
force-pushed
the
is_pm_isr_enable
branch
from
6e6a91e to
30dc9f9
Compare
lifenggitacc
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SoC warm reboot process, sometimes there are
instances where the ISH firmware fails to receive the
warm reboot request from PMC, leading to the failure to reboot
ISH firmware hence causing ISHTP kernel driver communication
failure with ISH firmware. This issue is observed when
there is an IPC request pending at the ISH and at the time
a warm reboot is initiated causing IPM driver timeout.
The IPM driver timeout is set to 1sec waiting for the Peer ACK.
Due to warm reboot, Peer ACK is not received leading to timeout
of 1sec. During this time ISH HW triggers the RESET
PREP IRQ, but we do not observe ISR routine executed at firmware
side which is expected to handle the warm reboot.
Changes done to perform ish pm init using zephyr SYS_INIT() in
PRE_KERNEL_2 stage. This change helps handle the IRQ rightly and
invokes the ISR routine to handle the firmware reset.
Change-Id: I454bd75257cdfc1c8f37e582231f6fe7f5e8f91d