sedi: Add CONFIG_LOG condition build for sedi_log API #67
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional compilation to the sedi_log() function based on the CONFIG_LOG configuration option. When logging is disabled, it provides a no-op implementation to prevent build errors.
- Wraps existing
sedi_log()implementation with#if CONFIG_LOGcondition - Adds stub implementation when
CONFIG_LOGis disabled that ignores parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kwd-doodling
force-pushed
the
dwang4_sedi_log
branch
from
4064949 to
7f1ed5e
Compare
The sedi_log() depends on Zephyr's log system. Signed-off-by: Dong Wang <dong.d.wang@intel.com>
kwd-doodling
force-pushed
the
dwang4_sedi_log
branch
from
7f1ed5e to
0b7929e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kwd-doodling
requested review from
lifenggitacc and
likongintel
as code owners
likongintel
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sedi_log() depends on Zephyr's log system.