fix: Upgrade markmap dependencies to resolve security vulnerabilities #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade esbuild from ^0.19.0 to ^0.27.2 (fixes moderate severity vulnerability) - Upgrade markmap-cli from ^0.16.0 to ^0.18.12 (fixes high severity hono vulnerabilities) - Update create-bundle.js to auto-detect CLI entry point (dist/cli.js vs dist/index.js) - Update markmap-wrapper.js to handle both old and new execution patterns - Maintain backward compatibility with both package versions - Build tested and verified working with all dependencies bundled Signed-off-by: Fang, Xiaoran <xiaoran.fang@intel.com>
kimtaeyo
approved these changes
Dec 31, 2025
Contributor
kimtaeyo
left a comment
kimtaeyo
left a comment
There was a problem hiding this comment.
It works as expected. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades esbuild and markmap-cli dependencies to resolve security vulnerabilities while maintaining backward compatibility.
Changes
Technical Details
The markmap-cli 0.18.12 introduced breaking changes in its package structure:
dist/index.jstodist/cli.jsmain()function export, now executes directly on requireSolution:
create-bundle.jsto auto-detect the correct CLI entry pointmarkmap-wrapper.jsto handle both old and new execution patternsTesting
Security Impact
Resolves npm audit vulnerabilities:
Only remaining vulnerability is in pkg (dev dependency, no fix available).