replace sycl::queue* with sycl::queue and rename dp.cpp files#17
Open
dc3671 wants to merge 1 commit intointel:mainfrom
Open
replace sycl::queue* with sycl::queue and rename dp.cpp files#17dc3671 wants to merge 1 commit intointel:mainfrom
dc3671 wants to merge 1 commit intointel:mainfrom
Conversation
Contributor
|
I'm okay with the change. Need to check UT passrate. |
Author
|
@delock How to run UT? Anyone could help to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not use
sycl::queuein pointer format. It's already a container of actual pointer(from https://intel.github.io/llvm-docs/doxygen/queue_8hpp_source.html):Also, we should not use
*.dp.cppas filenames. Just use*.cpp.We applied these modifications in our forked repo for transform inference part. We can apply these to other parts in this repo,too.
@delock @CaoZhongZ