Skip to content

replace sycl::queue* with sycl::queue and rename dp.cpp files#17

Open
dc3671 wants to merge 1 commit intointel:mainfrom
dc3671:replace-sycl-queue
Open

replace sycl::queue* with sycl::queue and rename dp.cpp files#17
dc3671 wants to merge 1 commit intointel:mainfrom
dc3671:replace-sycl-queue

Conversation

@dc3671
Copy link
Copy Markdown

@dc3671 dc3671 commented Apr 24, 2023

We should not use sycl::queue in pointer format. It's already a container of actual pointer(from https://intel.github.io/llvm-docs/doxygen/queue_8hpp_source.html):

image

Also, we should not use *.dp.cpp as filenames. Just use *.cpp.

We applied these modifications in our forked repo for transform inference part. We can apply these to other parts in this repo,too.

@delock @CaoZhongZ

@delock
Copy link
Copy Markdown
Contributor

delock commented Apr 24, 2023

I'm okay with the change. Need to check UT passrate.

@dc3671
Copy link
Copy Markdown
Author

dc3671 commented Apr 25, 2023

@delock How to run UT? Anyone could help to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants