-
Notifications
You must be signed in to change notification settings - Fork 34
KVM: Add KVM ras cases #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ee2723 to
0fe8b74
Compare
KVM/qemu/tests/ras.py
Outdated
| hw_mce = 'err_code:0x00a0:0x0090 SystemAddress:0x%s' % host_pha.lstrip('0x') | ||
| vm_mce = 'mce: Uncorrected hardware memory error in user-access at %s' % guest_pha.lstrip('0x') | ||
| hw_dmesg = process.system_output('dmesg').decode('utf-8') | ||
| s, vm_dmesg = session.cmd_status_output('dmesg') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments, need check "s".
KVM/qemu/ras.cfg
Outdated
| - srao: | ||
| error_type = "0x10" | ||
| variants: | ||
| - vm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this variant "vm" necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I planned to add TDX case after the kernel bug get fixed.
But I just aligned with dev, TD case may need kselftest or kernel module support, will remove the "vm" here.
KVM/qemu/tests/ras.py
Outdated
|
|
||
| def prepare_vm_victim(test, params, vm=None, session=None): | ||
| """ | ||
| Compile test tool victim in host or guest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this function only support VM only according to the implementation, such as: vm.copy_files_to(), session.cmd_status(), so the description need to be updated, and parameter "vm" and "session" are not optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I planned to deploy it for host, then found it is not necessary for this case, will clean this host setup
Signed-off-by: Farrah Chen <farrah.chen@intel.com>
|
@xhao22 Thanks for your comment, all comments have been addressed, could you take a look again? |
No description provided.