Skip to content

Conversation

@fanchen2
Copy link
Contributor

No description provided.

@fanchen2 fanchen2 force-pushed the dev-fan branch 23 times, most recently from 4ee2723 to 0fe8b74 Compare December 22, 2025 03:03
hw_mce = 'err_code:0x00a0:0x0090 SystemAddress:0x%s' % host_pha.lstrip('0x')
vm_mce = 'mce: Uncorrected hardware memory error in user-access at %s' % guest_pha.lstrip('0x')
hw_dmesg = process.system_output('dmesg').decode('utf-8')
s, vm_dmesg = session.cmd_status_output('dmesg')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comments, need check "s".

KVM/qemu/ras.cfg Outdated
- srao:
error_type = "0x10"
variants:
- vm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this variant "vm" necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned to add TDX case after the kernel bug get fixed.
But I just aligned with dev, TD case may need kselftest or kernel module support, will remove the "vm" here.


def prepare_vm_victim(test, params, vm=None, session=None):
"""
Compile test tool victim in host or guest.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this function only support VM only according to the implementation, such as: vm.copy_files_to(), session.cmd_status(), so the description need to be updated, and parameter "vm" and "session" are not optional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I planned to deploy it for host, then found it is not necessary for this case, will clean this host setup

Signed-off-by: Farrah Chen <farrah.chen@intel.com>
@fanchen2
Copy link
Contributor Author

@xhao22 Thanks for your comment, all comments have been addressed, could you take a look again?

@xhao22 xhao22 merged commit 210be56 into intel:main Dec 24, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants