[Benchmarks] add Record and Replay benchmarks #20481
Draft
+277
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
reble
reviewed
Oct 27, 2025
lslusarczyk
changed the title
lslusarczyk
force-pushed
the
rr_benchmarks
branch
from
fb1858a to
518f3b8
Compare
lslusarczyk
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
PatKamin
reviewed
Oct 28, 2025
PatKamin
reviewed
Oct 28, 2025
| "./devops/scripts/benchmarks/main.py", | ||
| self.WORKDIR_DIR, | ||
| "--sycl", | ||
| os.environ.get("ONEAPI_ROOT"), |
There was a problem hiding this comment.
Add info that oneapi has to be installed and sourced for sycl benchmarks tests
There was a problem hiding this comment.
I see that you've changed the code so that oneapi is no more needed. Please, remove the comment. This CMPLR_ROOT env var is set directly in the workflow file.
|
|
||
| metadata = out.metadata[testName] | ||
| self.assertEqual(metadata["type"], "benchmark") | ||
| self.assertEqual(set(metadata["tags"]), {"L0", "latency", "micro", "submit"}) |
There was a problem hiding this comment.
Also check if group metadata for this benchmark has been created in data.json
There was a problem hiding this comment.
Please precise what path in json I need to verify
There was a problem hiding this comment.
benchmark_group = metadata["explicit_group"]
group_metadata = out.metadata[benchmark_group]
self.assertEqual(group_metadata["type"], "group")
| Returns: | ||
| bool: True if the repository was cloned or updated, False if it was already up-to-date. | ||
| """ | ||
| if os.environ.get("LLVM_BENCHMARKS_UNIT_TESTING") == "1": |
There was a problem hiding this comment.
should we describe this env var somewhere?
There was a problem hiding this comment.
All new env vars should be described in some tests' readme
lslusarczyk
force-pushed
the
rr_benchmarks
branch
from
fd812e1 to
269c808
Compare
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lslusarczyk
force-pushed
the
rr_benchmarks
branch
from
269c808 to
4ac4f56
Compare
lslusarczyk
force-pushed
the
rr_benchmarks
branch
from
f7a16dc to
5b25f63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with unittest support