[SYCL][SPIRV BE] Enable only selected SPIR-V extensions for SPIR-V backend. #20497
+32
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…tel#20489) SPIR-V backend supports some extensions that our driver doesn't support yet (e.g. SPV_KHR_float_controls2), resulting in errors. This patch stops enabling all the SPIR-V backend supported extensions, and instead enables only a list of selected extensions. The list contains the intersection of extensions enabled for llvm-spirv with the extensions supported by the SPIR-V backend.
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jsji
pushed a commit
that referenced
this pull request
Oct 29, 2025
…ckend.(#20497) 20489 had to be reverted because -spirv-ext=-all is not valid in the SPIR-V BE. All the extensions are disabled by default, so we only need to explicitly enable those we require.
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| // - handle -Xspirv-translator option to avoid "argument unused during | ||
| // compilation" error | ||
| // - handle --spirv-ext=+<extension> and --spirv-ext=-<extension> options | ||
| // All the extensions disabled by default. We do this because there are some |
There was a problem hiding this comment.
nit: All the extensions are disabled by default.
srividya-sundaram
approved these changes
Oct 29, 2025
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Closing in favour of #20519. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20489 had to be reverted because
-spirv-ext=-allis not valid in the SPIR-V BE. All the extensions are disabled by default, so we only need to explicitly enable those we require.