[VP]Remove -DLINUX pre-compile definitions#1396
Open
ljia5 wants to merge 1 commit intointel:masterfrom
Open
Conversation
Remove -DLINUX pre-compile definitions Fixes: intel#449
ljia5
requested review from
Jexu,
alariono,
ansokolo and
guowillyy
as code owners
dvrogozh
suggested changes
Apr 25, 2022
Contributor
dvrogozh
left a comment
dvrogozh
left a comment
There was a problem hiding this comment.
That's correct for Linux, but will cause issues and more work on BSD side. See #1296 (comment). I think we need a buy off from @jbeich and bsd maintainers to merge this in, I mean we could merge this in if they are ok to provide a follow up patch to handle BSD part.
Contributor
I mean, they have provided patches (#819) but the patches have been pretty much entirely ignored by anyone with the ability to merge them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove -DLINUX pre-compile definitions
Fixes: #449