Skip to content

Conversation

@XuehaoSun
Copy link
Contributor

@XuehaoSun XuehaoSun commented Oct 28, 2025

User description

Type of Change

feature or bug fix or documentation or validation or others
API changed or not

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed


PR Type

Enhancement, Bug fix


Description

  • Update torch and docker versions

  • Refactor PyTorch model configurations

  • Improve Docker cleanup process

  • Remove unused code


Diagram Walkthrough

flowchart LR
  A["Update torch version"] -- "in install_nc.sh" --> B["Update docker version"]
  B -- "Refactor PyTorch model configs" --> C["Improve Docker cleanup"]
  C -- "Remove unused code" --> D["Enhance CI configuration"]
Loading

File Walkthrough

Relevant files
Enhancement
4 files
version.py
Update version number                                                                       
+1/-1     
run_pytorch_models_trigger.sh
Refactor PyTorch model configurations                                       
+2/-28   
install_nc.sh
Update torch and torchvision versions                                       
+2/-2     
model-template.yml
Update Docker tag and improve cleanup                                       
+3/-2     
Bug fix
2 files
run_basic_adaptor.sh
Update LD_LIBRARY_PATH                                                                     
+1/-1     
run_3x_pt.sh
Update LD_LIBRARY_PATH                                                                     
+1/-1     
Additional files
12 files
Dockerfile.devel +8/-1     
DockerfileCodeScan.devel +3/-1     
ubuntu-2404.devel +52/-0   
run_onnxrt_models_trigger.sh +0/-62   
run_tensorflow_models_trigger.sh +0/-118 
code-scan-template.yml +2/-1     
docker-template.yml +4/-3     
ut-template.yml +6/-2     
ut-3x-pt.yml +5/-2     
ut-3x-tf.yml +2/-1     
check-stale-issue.yml +1/-0     
README.md +1/-1     

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Issue

The script now only handles two specific models (opt_125m_woq_gptq_int4 and opt_125m_woq_gptq_nf4_dq_bnb). Other models like resnet18, resnet18_fx, and opt_125m_woq_gptq_int4_dq_ggml are removed without any handling. Ensure that these models are no longer needed or add appropriate handling.

if [ "${model}" == "opt_125m_woq_gptq_int4" ]; then
    model_src_dir="nlp/huggingface_models/language-modeling/quantization/weight_only"
    inc_new_api=3x_pt
    tuning_cmd="bash run_quant.sh --topology=opt_125m_woq_gptq_int4"
elif [ "${model}" == "opt_125m_woq_gptq_nf4_dq_bnb" ]; then
    model_src_dir="nlp/huggingface_models/language-modeling/quantization/weight_only"
    inc_new_api=3x_pt
    tuning_cmd="bash run_quant.sh --topology=opt_125m_woq_gptq_nf4_dq_bnb"
fi
Hardcoded Path

The LD_LIBRARY_PATH is set to ${HOME}/.local/lib/. This might not be suitable for all environments. Consider making this configurable or using a more generic path.

export LD_LIBRARY_PATH=${HOME}/.local/lib/:$LD_LIBRARY_PATH
Container Cleanup

The script now stops and removes the Docker container. Ensure that this does not interfere with other processes that might be using the same container name.

docker stop ${{ parameters.codeScanContainerName }}
docker rm -vf ${{ parameters.codeScanContainerName }} || true

@PRAgent4INC
Copy link
Collaborator

Failed to generate code suggestions for PR

Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants