-
Notifications
You must be signed in to change notification settings - Fork 70
Enable Python EVT Compute UT #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables Epilogue Visitor Tree (EVT) Python unit tests for Intel XPU devices (PVC/Xe12 and BMG/Xe20) by adding device detection, platform-specific implementations, and adapting test infrastructure to work with both CUDA and SYCL backends.
Key changes:
- Add Intel Xe12 (PVC) and Xe20 (BMG) support to EVT backend with new node implementations and emitters
- Update device detection to differentiate between BMG (CC=20) and PVC (CC=12) Intel GPUs
- Modify test infrastructure to support XPU tensors and dynamic device selection (CUDA/XPU/CPU)
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
test/python/cutlass/evt/utils/evt_testbed.py |
Adds dynamic device selection for PyTorch tensors (CUDA/XPU/CPU) |
test/python/cutlass/evt/evt_store_sm80_90.py |
Extends test CC support to include Intel Xe12 (12) and Xe20 (20) |
test/python/cutlass/evt/evt_mixed_sm80_90.py |
Extends test CC support to include Intel Xe12 (12) and Xe20 (20) |
test/python/cutlass/evt/evt_load_sm80_90.py |
Extends test CC support to include Intel Xe12 (12) and Xe20 (20) |
test/python/cutlass/evt/evt_layout_sm80_90.py |
Extends test CC support to include Intel Xe12 (12) and Xe20 (20) |
test/python/cutlass/evt/evt_compute_sm80_90.py |
Extends test CC support to include Intel Xe12 (12) and Xe20 (20) |
python/cutlass_cppgen/backend/utils/device.py |
Adds BMG device detection logic to return CC=20 for Battlemage GPUs |
python/cutlass_cppgen/backend/operation.py |
Replaces CUDA-specific return value with generic success code (0) |
python/cutlass_cppgen/backend/gemm_operation.py |
Updates architecture checks and error handling for XPU compatibility |
python/cutlass_cppgen/backend/frontend.py |
Fixes XPU tensor detection and device pointer handling logic |
python/cutlass_cppgen/backend/evt/passes/pass_manager.py |
Adds Xe-specific function name resolution based on device availability |
python/cutlass_cppgen/backend/evt/passes/pass_get_impl.py |
Adds Xe-prefix support for node implementation lookup |
python/cutlass_cppgen/backend/evt/passes/pass_argument_type.py |
Adds xe12/xe20 argument type handling methods |
python/cutlass_cppgen/backend/evt/frontend/frontend_base.py |
Updates CC checks to include Intel Xe12/Xe20 architectures |
python/cutlass_cppgen/backend/evt/epilogue.py |
Adds Xe emitter selection and updates CC checks |
python/cutlass_cppgen/backend/evt/backend/xe20_nodes.py |
New file implementing Xe20-specific EVT node types |
python/cutlass_cppgen/backend/evt/backend/xe20_emitter.py |
New file implementing Xe20 epilogue emitter |
python/cutlass_cppgen/backend/evt/backend/xe12_nodes.py |
New file implementing Xe12-specific EVT node types |
python/cutlass_cppgen/backend/evt/backend/xe12_emitter.py |
New file implementing Xe12 epilogue emitter |
python/cutlass_cppgen/backend/evt/backend/__init__.py |
Registers new Xe12 and Xe20 emitters and nodes |
python/cutlass_cppgen/backend/compiler.py |
Changes default SYCL target from PVC to BMG |
python/cutlass_cppgen/backend/arguments.py |
Adds comprehensive XPU support with device pointer handling |
Antonyvance
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistakenly approved. Need explanation for the comments.
Antonyvance
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it make sense to typdef instead of just using sm90 (it would avoid the confusion and will set direction to add support for future architecture. Okay to make the changes in next revision
3df8e41 to
7c4c87c
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
7c4c87c to
9efd3a2
Compare
This PR depends on #647