Added support for Column Major C [Bias] in GEMM #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kausikmaiti
force-pushed
the
column_major
branch
3 times, most recently
from
31cdc64 to
d19437b
Compare
kausikmaiti
changed the title
kausikmaiti
requested review from
Antonyvance,
amitchawla1,
anamikac-intel,
nsingh-habana,
rolandschulz and
tdeng5
petercad
reviewed
Dec 9, 2025
petercad
reviewed
Dec 9, 2025
kausikmaiti
force-pushed
the
column_major
branch
3 times, most recently
from
b01175c to
9253503
Compare
kausikmaiti
force-pushed
the
column_major
branch
from
9253503 to
244388f
Compare
Following changes have been made.
1. XE_LOAD_2D or XE_LOAD_2D_TRANSPOSE used in TiledCopyC based on C [Bias] layout.
2. Static assertion check on C [Bias] layout in xe_builder.inl removed.
3. Reference output generation function GemmComplex fixed.
4. 00_bmg_gemm_bias.cpp example added to test gemm with bias.
5. Python test xe20_gemm_bf16.py updated to test gemm with bias.
Signed-off-by: Maiti, Kausik <kausik.maiti@intel.com>
kausikmaiti
force-pushed
the
column_major
branch
from
244388f to
0961845
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Column Major C [Bias] in GEMM.
Following changes have been made.
1. XE_LOAD_2D or XE_LOAD_2D_TRANSPOSE used in TiledCopyC based on C [Bias] layout.
2. Static assertion check on C [Bias] layout in xe_builder.inl removed.
3. Reference output generation function GemmComplex fixed.
4. 00_bmg_gemm_bias.cpp example added to test gemm with bias.
5. Python test xe20_gemm_bf16.py updated to test gemm with bias.