fix output shape for FMHA forward kernel #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ClarkChin08 Please help take a look here. |
Author
|
@rolandschulz Please also review here. |
Author
|
@rolandschulz Could you please help review and trigger CI here? |
Author
|
Umm, CI failures are not related to changes... |
ClarkChin08
approved these changes
Dec 31, 2025
tdeng5
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix output shape of FMHA forward kernel, otherwise it will give wrong results when
is_var_len=Trueandnum_heads_kv=1.Type
Testing
Performance
References
Fixes #
Checklist