Fix C compilation issue for xpum_struct.h #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ructor Default constructor not valid for C compilation.
if defined(__cplusplus) for xpum_vgpu_precheck_result_t default const…
|
We are planning to remove the constructor. |
|
Constructor was removed in V1.2.17 (Aug 2023): https://github.com/intel/xpumanager/blob/master/core/include/xpum_structs.h#L1159 So this PR can be closed. |
|
@saik-intel Could you close this? The issue this PR would fix, was gone already n V1.2.17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default constructor not valid for C compilation.
Guard xpum_vgpu_precheck_result_t default constructor with
if defined(__cplusplus)