APPS-24412: add GitHub iOS build workflow (without SPM support yet)#113
APPS-24412: add GitHub iOS build workflow (without SPM support yet)#113CristianoCastroIntm wants to merge 2 commits intorelease/im-2.14.1from
Conversation
| cd ios_framework | ||
| ./build_ios_framework.sh \ | ||
| --source-dir="${{ github.workspace }}" \ | ||
| --output-dir="$PWD/artifact" \ |
There was a problem hiding this comment.
Here we have hidden coupling with OUTPUT_DIR constant.
There was a problem hiding this comment.
Correct. This one might be tricky, because we are cding into the ios_framework to run the build script (like we do on TFS). We can't run in from the root otherwise it will fail because it expects some files to be in the current directory. That being said, the script can be changed to try and accommodate this, but it was not my original intention (which was to simply/mostly to mirror what was already being done).
How do you like me to proceed?
There was a problem hiding this comment.
Then, what is the reason for OUTPUT_DIR constant? I see we can easily remove it
| push: | ||
| tags: | ||
| - "*" | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Don't you think it is better to make two separate flows: one for tag and one for manual build?
There was a problem hiding this comment.
Removed push tags trigger and related code and renamed workflow to have "manual" suffix like we do for other ones
… and removed unnecessary code
CristianoCastroIntm
deleted the
feature/APPS-24412_github_ios_build_no_SPM
branch
2 participants
JIRA Issue
Description