Added internationalization support for Philippines(PH) translation#12233
Open
bdb-lab wants to merge 4 commits intointernetarchive:masterfrom
Open
Added internationalization support for Philippines(PH) translation#12233bdb-lab wants to merge 4 commits intointernetarchive:masterfrom
bdb-lab wants to merge 4 commits intointernetarchive:masterfrom
Conversation
Collaborator
|
Closing as this does not follow our contributing guidelines (https://docs.openlibrary.org/developers/CONTRIBUTING.html) In this case, you're opening a PR before you're assigned to an issue. It's important that you're assigned to ensure it's an issue that staff are prioritizing to review and work on. If no issue exists you can create it. Thanks for understanding and we welcome you to find another issue follow the process linked above. |
Member
|
Hi! This is actually a followup of a previous PR -- the previous PR shows up in the list of updates on this PR but it doesn't show up as linked. Here's some additional context: We're happy to help take this over the finish line with you @bdb-lab, apologies for the mixup |
removed unnecessary comment causing build fail
Update messages.po for plural issue
Author
|
thanks for remind bro @RayBB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEATURE: Adds internationalization support for Philippines, country = PH(Filipino)
Technical
Testing
Screenshot
Stakeholders