Open
Conversation
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
sg-gs
reviewed
Jan 26, 2026
| bucketId: string, | ||
| ): Promise<[Folder, Folder, Folder]> { | ||
| const rootFolderName = this.cryptoService.encryptName(`${v4()}`); | ||
| const rootFolderName = v4(); |
Member
There was a problem hiding this comment.
I do not know the side effects of this case. A root folder's name should not be decrypted in any case, as there is no level above it and thus, it does not have any folders at its same level too.
LGTM assuming that, but double check it @jzunigax2
sg-gs
reviewed
Jan 26, 2026
src/modules/folder/folder.usecase.ts
Outdated
|
|
||
| const folderWithSameNameExists = await this.folderRepository.findOne({ | ||
| name: cryptoFileName, | ||
| name: newFolderMetadata.plainName, |
Member
There was a problem hiding this comment.
This could not be done, it's not consistent. The already existent items have their names encrypted. The new ones won't. You may introduce an OR here. Or even better: switch from findOne using the name to use the plainName, as we should deprecate this field.
Contributor
Author
There was a problem hiding this comment.
Switched to plainName for findOne: f713435
sg-gs
requested changes
Jan 26, 2026
Member
sg-gs
left a comment
sg-gs
left a comment
There was a problem hiding this comment.
Left some comments @TamaraFinogina
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
had a problem deploying
to
development
GitHub Actions
Failure
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
|
This PR is stale because it has been open for more than 15 days with no activity. |
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
TamaraFinogina
temporarily deployed
to
development
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the name equal to plainName instead of its encrypted version.