-
-
Notifications
You must be signed in to change notification settings - Fork 16
Tags flairs #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Tags flairs #314
Conversation
Store and display user tags.
Update tag icons. Update padding.
|
After looking through the app a bit more with this, I have a few recommendations to make:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would there be a better way to display user tags without having to wrap every instance of a post or comment to add in the tags? For example, if we instead moved this to the ContentItem widget, and checked if the passed in username matched with any local tags, then it would add in the extra tags next to the PieFed flairs.
The way it's done right now just seems like it would be easy to mess up in the future (like forgetting to use applyUserTagsComment where it should be).
Another issue I see with it is that post flairs and local user tags are merged together and treated as the same. What happens if we allow editing the flairs of a post later on, and the local tags show up just the same as the flairs and are indistinguishable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing it directly in content item is indeed much easier and cleaner. There is a little pop in when the tags are fetched but its not easily noticeable so no worries.
The post flairs and user tags are stored separately. I've started working on editing post flairs and user flairs getting in the way shouldn't be an issue. It would be nice to have a visual difference between them though. Maybe a border around one of them with the same colour as the text would work to differentiate them.
… based on background luminance. - Remove add redundant add new tag on user_tags screen. - Move add tags buttons to top of respective screens so don't have to scroll. - Database adjustments for tags.
|
# Conflicts: # lib/src/models/post.dart # lib/src/screens/feed/post_item.dart # lib/src/utils/utils.dart # lib/src/widgets/content_item/content_item.dart
jwr1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and merge this, but I do have a few changes I want to personally make. I'll do it in a separate pr though so you can review them.
Adds support for Piefed post flairs and user flairs/tags.
Adds user tags.