Skip to content

Small improvements for the benefit of contributors #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isc-tleavitt merged 6 commits into from
Dec 10, 2025
Merged

Small improvements for the benefit of contributors #851

isc-tleavitt merged 6 commits into from
Dec 10, 2025

Conversation

@gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Jul 25, 2025 •
edited
Loading

  • Use public registry when getting Docker images.
  • Avoid recommending a superseded extension.
  • Remove need to change settings.json if port had to be altered in docker-compose.yml
  • Set the container up to produce test coverage reports in VS Code using the InterSystems Testing Manager extension

@gjsjohnmurray
Get IRIS images from a public registry
a1e0590
@gjsjohnmurray
CONTRIBUTING.md says default oras image should be the amd64 one
987d92f
@gjsjohnmurray
Update an extension recommendation
978b501 
Docker extension pack has been officially superseded by Container Tools
@gjsjohnmurray
Use docker-compose setting in objectscript.conn
0173219 
This means that if a contributor needs to alter docker-compose.yml because their port 52774 isn't free they won't also have to change settings.json
@gjsjohnmurray
Changes to support use of InterSystems Testing Manager extension for …
0d1980d 
…coverage
@gjsjohnmurray
Merge branch 'intersystems:main' into sapphire-rhinoceros
02c9b40
@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jul 28, 2025

Pinging @isc-tleavitt because of the Test Coverage Tool integration this facilitates.

isc-tleavitt
isc-tleavitt approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@isc-tleavitt isc-tleavitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gjsjohnmurray sorry this has sat for a ridiculously long time!

This is uncontroversial and should just be merged.

@isc-tleavitt isc-tleavitt merged commit ea5b5de into intersystems:main Dec 10, 2025
@gjsjohnmurray gjsjohnmurray deleted the sapphire-rhinoceros branch December 10, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isc-tleavitt isc-tleavitt isc-tleavitt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gjsjohnmurray @isc-tleavitt