Skip to content

Conversation

@codekeyz
Copy link
Contributor

No description provided.

@codekeyz codekeyz self-assigned this Feb 10, 2025
@codekeyz codekeyz requested a review from Copilot April 26, 2025 13:07
@codekeyz codekeyz added the enhancement New feature or request label Apr 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new CI build job to build and release the Globe Runtime Shared Library while updating the CHANGELOG.

  • Added CHANGELOG entry for the initial version
  • Introduced a GitHub Actions workflow for building and releasing the shared library

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
CHANGELOG.md New changelog entry recording the initial version
.github/workflows/build.yaml CI workflow added for building and releasing the shared library

@codekeyz codekeyz requested a review from Copilot April 28, 2025 14:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a CI build job while cleaning up and standardizing some build configuration details. Key changes include:

  • Refactoring the build script (build.rs) to create a mutable build instance with conditional flag configuration.
  • Renaming the crate in Cargo.toml from "_globe_runtime" to "globe_runtime".
  • Adding a GitHub Actions workflow to automate the CI build process of the shared library.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
build.rs Refactored C code compilation process with clearer flag handling for Windows vs Unix.
Cargo.toml Updated the library name to a conventional value.
CHANGELOG.md Added an initial changelog entry.
.github/workflows/build.yaml Introduced a comprehensive CI workflow for building and publishing the shared library.
Files not reviewed (1)
  • packages/globe_neon/lib/src/globe_neon_base.dart: Language not supported

@codekeyz codekeyz merged commit 4b15bbb into main Apr 28, 2025
7 checks passed
@codekeyz codekeyz deleted the chore/add-ci-job branch April 28, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants