Enable bash history under spryker console#638
Closed
Chemaclass wants to merge 1 commit intoinviqa:1.2.xfrom
Chemaclass:feature/mount-bash-history-in-harness
Closed
Enable bash history under spryker console#638Chemaclass wants to merge 1 commit intoinviqa:1.2.xfrom Chemaclass:feature/mount-bash-history-in-harness
Chemaclass wants to merge 1 commit intoinviqa:1.2.xfrom
Chemaclass:feature/mount-bash-history-in-harness
Conversation
Contributor
|
Thank you for porting it from the other repo but #635 is already here 🥳 |
Contributor
|
Though actually, that PR doesn't cover the |
Contributor
Author
|
@kierenevans jap, #635 is updating |
|
I wasn't aware, we need the mounting in |
Contributor
|
_base is the base layer, spryker is layered on top of that so need to apply to every |
Contributor
Author
|
I close this PR in favor of the one from @alexandrajulius #635 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original idea by @alexandrajulius 🙌
🛠 Manual steps
This will create an empty file .bash_history in
/.my127wsand it will mount your local bash history to that file.Therefore, after exiting and entering the console container again, you will still have your bash history available.
🤔 Open questions
Maybe does it make sense to add this mounting to the _base console template? Or all other as well?
src/_base/_twig/docker-compose.yml/service/console.yml.twigAnswer: #635 ☝️