Open
Conversation
| version: develop | ||
| console: | ||
| healthcheck: | ||
| enabled: true |
Contributor
There was a problem hiding this comment.
can it be enabled for helm and CI as well? It's useful for seeing the deployment readiness, and CI should act the same as local
Contributor
There was a problem hiding this comment.
technically helm way is enough being a common console.healthcheck.enabled, as it'll get the same file CI was built from
Contributor
There was a problem hiding this comment.
note though that the helm way is hard coded to app state
Co-authored-by: andytson-inviqa <andytson-inviqa@users.noreply.github.com>
Co-authored-by: andytson-inviqa <andytson-inviqa@users.noreply.github.com>
Contributor
|
I'm a bit nervous of the PR still, but now this sort of thing also needs to be a docker harness thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #666
Introduce Docker HealthCheck for local builds of the
consoleThe health check process:
docker-composerwill wait for the HealthCheck command to find theconsolecontainer in a healthy status before releasing control over the containers to the following commandsDefaults:
/HEALTHCHECK.txtfile/healthcheck.test.shscripthealthcheck.test.shis populated with steps that check if/HEALTHCHECK.txthas been created