Skip to content

Fix(backend): Fix race condition in download queue when concurrent jobs share same destination #8931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lstein wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −13
Open

Fix(backend): Fix race condition in download queue when concurrent jobs share same destination #8931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions invokeai/app/services/download/download_default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright (c) 2023, Lincoln D. Stein
# Copyright (c) 2023,2026 Lincoln D. Stein
"""Implementation of multithreaded download queue for invokeai."""

import os
Expand Down Expand Up @@ -388,18 +388,23 @@ def _do_download(self, job: DownloadJob) -> None:
if len(candidates) == 1:
inferred = candidates[0].with_name(candidates[0].name.removesuffix(".downloading"))
job.download_path = inferred
resume_from = candidates[0].stat().st_size
job.bytes = resume_from
self._logger.debug(
f"Resume check (dir): inferred in-progress file path={candidates[0]} size={resume_from} bytes"
)
if resume_from > 0:
if job.etag:
header["If-Range"] = job.etag
elif job.last_modified:
header["If-Range"] = job.last_modified
header["Range"] = f"bytes={resume_from}-"
open_mode = "ab"
try:
resume_from = candidates[0].stat().st_size
except FileNotFoundError:
# The .downloading file was renamed/deleted between glob and stat (race condition); skip resume.
job.download_path = None
else:
job.bytes = resume_from
self._logger.debug(
f"Resume check (dir): inferred in-progress file path={candidates[0]} size={resume_from} bytes"
)
if resume_from > 0:
if job.etag:
header["If-Range"] = job.etag
elif job.last_modified:
header["If-Range"] = job.last_modified
header["Range"] = f"bytes={resume_from}-"
open_mode = "ab"
else:
self._logger.debug(
"Resume check (dir): no prior download_path available; cannot resume from disk "
Expand Down