Remove various confusing and apparently out-of-date ignores.#617
Open
ceball wants to merge 1 commit intoioam:masterfrom
Open
Remove various confusing and apparently out-of-date ignores.#617ceball wants to merge 1 commit intoioam:masterfrom
ceball wants to merge 1 commit intoioam:masterfrom
Conversation
Member
|
For all of these, if we can't think of any good reason to ignore, I think we should stop ignoring and then re-ignore if we later encounter annoyances. Ignoring should only be for things that really are real problems if we don't. By number:
I don't think we should be ignoring include, info, and things like that in any case -- those are left over from when we had full builds that were installing things in the main topographica directory. Nowadays I don't think we need bin, lib, include, info, man, share listed there; I think that's all out of date. |
c1e467b to
cb0aaf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for discussion rather than immediate merging, because probably I'm not right about all of these, but e.g. the ignoring of notebooks in the root directory confused me, so I looked at .gitignore and went down a bit of a rabbit hole...
(listed in order they appear in the diff, just about)
external/*)?index.rstplus generated files, i.e. no new human-added files. And I guess you want to ignore generated .rst files (since there's alsoReference_Manual/*-module.rstin the .gitignore for doc), in which case probably I shouldn't have removed this line.notebooksdirectory is no longer used, right? Or I've missed it?_buildto the main .gitignore, removed*.pyc(redundant), and removed what I think might be out-of-dateReference_Manual/*-module.rst(might be wrong about that...).Also, you can see things like
include(line 18) will cause anything calledincludeto be ignored throughout the repository, whereas e.g./doc/_buildis being explicit about ignoring onlydoc/buildfrom the root, not from anywhere elsedoc/_buildmight appear. Probably worth going through each and deciding which it's supposed to be.