Skip to content

Remove NJH6D3T4YV reference from project.pbxproj #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ioboi merged 1 commit into from
Nov 20, 2025
Merged

Remove NJH6D3T4YV reference from project.pbxproj #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .github/workflows/verify-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Verify Build Configuration
on:
pull_request:
paths:
- "CubeSight.xcodeproj/project.pbxproj"
- ".github/workflows/verify-config.yml"

jobs:
verify-development-team-uses-variables:
name: Verify Development Team Configuration
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4

- name: Check DEVELOPMENT_TEAM configuration
run: |
echo "Checking DEVELOPMENT_TEAM configuration..."

# Find all DEVELOPMENT_TEAM assignments
TEAM_LINES=$(grep -n "DEVELOPMENT_TEAM = " CubeSight.xcodeproj/project.pbxproj || true)

if [ -z "$TEAM_LINES" ]; then
echo "⚠️ No DEVELOPMENT_TEAM found in project"
exit 0
fi

echo "Found DEVELOPMENT_TEAM entries:"
echo "$TEAM_LINES"
echo ""

# Check for lines that DON'T use variable reference syntax
BAD_LINES=$(echo "$TEAM_LINES" | grep -v 'DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";' || true)

if [ -n "$BAD_LINES" ]; then
echo "❌ Found DEVELOPMENT_TEAM entries not using variable reference:"
echo "$BAD_LINES"
echo ""
echo "All entries should use: DEVELOPMENT_TEAM = \"\$(DEVELOPMENT_TEAM)\";"
echo ""
echo "This ensures the team ID comes from Xcode's build settings"
echo "rather than being hardcoded in the project file."
exit 1
fi

echo "✅ All DEVELOPMENT_TEAM entries correctly use variable references"
4 changes: 2 additions & 2 deletions CubeSight.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = NJH6D3T4YV;
DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_TESTABILITY = YES;
ENABLE_USER_SCRIPT_SANDBOXING = YES;
Expand Down Expand Up @@ -390,7 +390,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = NJH6D3T4YV;
DEVELOPMENT_TEAM = "$(DEVELOPMENT_TEAM)";
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
ENABLE_USER_SCRIPT_SANDBOXING = YES;
Expand Down