Open
Conversation
Contributor
|
I look forward to seeing this feature merged!🙌 |
| "createModule": { | ||
| "type": "boolean", | ||
| "description": "Allows creating an NgModule for the page", | ||
| "default": true |
There was a problem hiding this comment.
I think default should set to be false so that we can keep existing changes without breaking it.
|
|
||
| const templateSource = apply(url('./files'), [ | ||
| options.spec ? noop() : filter(p => !p.endsWith('.spec.ts')), | ||
| options.createModule ? noop() : filter(p => !p.endsWith('.module.ts')), |
There was a problem hiding this comment.
It would be nice if we could add some unit tests to validate these changes and keep align with existing behavior. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligning the page schematic with the component schematic, which already offers
--create-module. The default for the page schematic istrue, unlike the component schematic. To disable module creation,--create-module=falsemust be specified.fixes https://github.com/ionic-team/ionic-cli/issues/3586