Skip to content

fix(button): fix colors and ripple-effect #30764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: next
Choose a base branch
from
Open

fix(button): fix colors and ripple-effect #30764

wants to merge 14 commits into from

Conversation

@JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Oct 30, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • fix outline and clear colors and ripple-effect;

Does this introduce a breaking change?

  • Yes
  • No

Other information

clear
outline
test theme

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the package: core @ionic/core package label Oct 30, 2025
@vercel
Copy link

vercel bot commented Oct 30, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 31, 2025 5:35pm

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd marked this pull request as ready for review October 30, 2025 18:52
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner October 30, 2025 18:52
thetaPC
thetaPC requested changes Oct 30, 2025
View reviewed changes
JoaoFerreira-FrontEnd and others added 7 commits October 31, 2025 12:36
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
543fc0a 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
5b948a8 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
399430e 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
6668907 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
9622114 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
5cf8e28 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@JoaoFerreira-FrontEnd @thetaPC
Update core/src/components/button/button.ionic.scss
1233b8c 
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
thetaPC
thetaPC requested changes Oct 31, 2025
View reviewed changes
@JoaoFerreira-FrontEnd
- clean ripple effect;
2037c36 
- clean warning rule;
- update solid background-activated var;
@gnbm gnbm requested a review from thetaPC October 31, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC Awaiting requested review from thetaPC

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoaoFerreira-FrontEnd @thetaPC @Ionitron