Open
Conversation
With Ruby 3.1 psych version gets bumped to 4.x, which changes the behavior of YAML.load to YAML.safe_load. Since this YAML content is controlled by this gem, we can assume it's safe to keep the old default behavior of unsafe_load. Since old psych versions don't implement unsafe_load, we need to dynamically evaluate which method to use at load time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Ruby 3.1 psych version gets bumped to 4.x, which changes the behavior of
YAML.loadtoYAML.safe_load. Since this YAML content is controlled by this gem, we can assume it's safe to keep the old default behavior ofunsafe_load.Since old psych versions don't implement
unsafe_load, we need to dynamically evaluate which method to use at load time.