Use PlistBuddy instead of defaults in scripts#7
Open
interstateone wants to merge 1 commit intoiovation:masterfrom
Open
Use PlistBuddy instead of defaults in scripts#7interstateone wants to merge 1 commit intoiovation:masterfrom
interstateone wants to merge 1 commit intoiovation:masterfrom
Conversation
The defaults command will sometimes fail with an error like this:
> The domain/default pair of (.../FraudForce.framework/Info.plist, CFBundleExecutable) does not exist
The defaults command seems intended for use with the macOS preferences system. Included in its man page is:
> WARNING: The defaults command will be changed in an upcoming major release to only operate on preferences domains. General plist manipulation utilities will be folded into a different command-line program.
Perhaps Catalina is that upcoming major release 😅
A better alternative to using defaults is PlistBuddy. If you replace the defaults command in slim-build-frameworks.sh with /usr/libexec/PlistBuddy -c "Print :CFBundleExecutable" "${OUTPUT_FRAMEWORK_PATH}/Info.plist" then it will return the same value and shouldn't fail with the error quoted above.
skwashua
approved these changes
Feb 24, 2020
skwashua
left a comment
skwashua
left a comment
There was a problem hiding this comment.
This fixed the Catalina related issue I was having.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The defaults command will sometimes fail with an error like this:
The defaults command seems intended for use with the macOS preferences system. Included in its man page is:
Perhaps Catalina is that upcoming major release 😅
A better alternative to using defaults is PlistBuddy. If you replace the defaults command in the scripts with /usr/libexec/PlistBuddy -c "Print :CFBundleExecutable" "${OUTPUT_FRAMEWORK_PATH}/Info.plist" then it will return the same value and shouldn't fail with the error quoted above.
Resolves #4