This repository was archived by the owner on Jan 5, 2026. It is now read-only.
Add support for VXLAN+IPSEC usecase for tunnel and transport mode#27
Draft
nupuruttarwar wants to merge 1 commit intomainfrom
Draft
Add support for VXLAN+IPSEC usecase for tunnel and transport mode#27nupuruttarwar wants to merge 1 commit intomainfrom
nupuruttarwar wants to merge 1 commit intomainfrom
Conversation
fcc0cc7 to
35aa883
Compare
aachary1
suggested changes
Dec 12, 2023
| DBG2(DBG_KNL, "Inline_crypto_ipsec ipsec_tx_sa_classification_table:" | ||
| "add entry failed"); | ||
|
|
||
| err = vxlan_ipsec_tx_sa_classification_table(IPSEC_TABLE_ADD, |
Contributor
There was a problem hiding this comment.
It seems this table will allow subnet mask in ip addresses. This is useful for tunnel mode only. If this table is used then the regular exact match fixed function table is not needed.
Instead of calling it vxlan* We can give a better name such as ipsec_tx_sa_classification_table_with_subnet().
This is only needed for tunnel mode. The exact match table will be used for transport mode. In this case we can reduce the no of arguments in this API !!
|
|
||
| // Program the same information in both the tables to support | ||
| // IPSEC ONLY and VXLAN+IPSEC case in one package | ||
| err = vxlan_ipsec_outer_ipv4_encap_mod_table(IPSEC_TABLE_ADD, |
Contributor
There was a problem hiding this comment.
This seems to be duplicate table. The existing ipsec_encap table is sufficient
| bool tunnel_mode, | ||
| char src_ip_mask[16], | ||
| char dst_ip_mask[16]); | ||
| extern "C" enum ipsec_status tep_term_with_ipsec_tunnel_table( |
Contributor
There was a problem hiding this comment.
Please describe purpose of this table.
To support VXLAN+IPSEC, information coming from strongswan is programmed in tables related to VXLAN+IPSEC along with IPSEC only case This modifications are tempory with D-river P4 Signed-off-by: nupuruttarwar <nupur.uttarwar@intel.com>
35aa883 to
94c4e28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support VXLAN+IPSEC, information coming from strongswan is programmed in tables related to VXLAN+IPSEC along with IPSEC only case