Skip to content

Conversation

@danielreardon
Copy link

Converts enterprise noise parameters to temponest for use in .par files with tempo2.

@paulthebaker
Copy link
Collaborator

These changes are specific to the trim dataset. They break make_dataset(), so it can no longer cut or classic datasets by hard coding in choices for particular pulsars. You should make these changes generalizable, so they can coexist with other use cases.

Currently this repo does not contain any .par or .tim files for any dataset. We instead saved dictionaries in the psrdicts directory, so that many dataset choices could be reproducibly generated using make_dataset() instead of keeping many near duplicate .par and .tim files.

@paulthebaker
Copy link
Collaborator

paulthebaker commented May 20, 2020

For a complicated data selection like this, it might make more sense to add a notebook that generates a filtering dictionaries compatible with the existing tools.

Your low_freq_cut could be implemented by setting fmax=1000 and bw=np.inf. This can be customized per pulsar by passing frequency_filter a dictionary.

Your legacy_cut likewise could be implemented by passing psrdict an appropriate dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants