Skip to content

Conversation

@paulray
Copy link
Contributor

@paulray paulray commented May 5, 2025

I updated the clock files manually since the workflow has been crashing since Feb 2024.
I'll file an issue to on the required fix.

@dlakaplan
Copy link
Contributor

Do you mean Feb 2025?

@dlakaplan
Copy link
Contributor

This is what I did last year to fix the BIPM 2023 file (same issue a year ago?)
#20

@paulray
Copy link
Contributor Author

paulray commented May 5, 2025

Oops, yes 2025! The problem was BIPM2024, so I had that on my brain

@dlakaplan
Copy link
Contributor

I just tried a simpler PR (#31) that should add BIPM 2024 like I did for BIPM 2023 last year, without commenting it out. We'll see if that passes (there could be other issues).

@dlakaplan
Copy link
Contributor

Is this PR still needed? It seemed like it updates a lot of files just from running the update script but they aren't actually substantive changes.


# C extensions
*.so
.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to start doing this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nicer for Mac people to not have that show up in git status

@paulray
Copy link
Contributor Author

paulray commented May 5, 2025

Correct. Not really needed, but I don't think it is any harm.

@paulray
Copy link
Contributor Author

paulray commented May 5, 2025

gps2utc_tempo2.clk has been deleted. It has evidently been replaced by gpst2utc.clk and is no longer in the repo.

@paulray
Copy link
Contributor Author

paulray commented May 5, 2025

I think this is somewhat overlapping with #24 but that PR doesn't seem to have any changes to the python

@JPGlaser JPGlaser merged commit db1e59b into ipta:main May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants