Skip to content
This repository was archived by the owner on Jun 30, 2023. It is now read-only.

make SubtaskTimeTrackingExportCommand work and export to CSV, not html#1

Open
liedekef wants to merge 6 commits intoipunkt:masterfrom
liedekef:master
Open

make SubtaskTimeTrackingExportCommand work and export to CSV, not html#1
liedekef wants to merge 6 commits intoipunkt:masterfrom
liedekef:master

Conversation

@liedekef
Copy link

@liedekef liedekef commented Apr 2, 2020

This commit make the SubtaskTimeTrackingExportCommand work (next to AllSubtaskTimeTrackingExportCommand) and exports to CSV as the rest of kanban does (this could result in some html-generating code to be removed).
Next to that a css part is removed that interferes with the latest kanboard code to allow timespent to be entered directly on the task upon creation too.

@dlazesz
Copy link

dlazesz commented May 20, 2020

Dear @liedekef,

In Plugin.php at line 8 the definition of SubtaskTimeTrackingExportCommand is missing, so an exception occurs.

To address this problem, please consider adding the following line after line 8:

use Kanboard\Plugin\Timetrackingeditor\Console\SubtaskTimeTrackingExportCommand;

Otherwise, I personally really like this addition and hope it to be merged soon!

@liedekef
Copy link
Author

Indeed, I fixed that already in my version, but forgot to add the use-line to the git source.

@dlazesz
Copy link

dlazesz commented May 21, 2020

Thank you!
Regarding the exported CSV, I would prefer to see not just the days, but also the time for the starting and ending timestamp.
Do you agree with changing SubtaskTimeTrackingExport.php#L125-126 from date() to datetime() or it is just me?

@liedekef
Copy link
Author

I'll take a look and see if that works and if so, change it.

@liedekef
Copy link
Author

Ok, since the command export:allsubtaskstimetracking already exports to datetime, I've changed that now for export:subtaskstimetracking too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants