README.md Sentence structure improvement#103
Open
Script47 wants to merge 2 commits intoircmaxell:masterfrom
Open
README.md Sentence structure improvement#103Script47 wants to merge 2 commits intoircmaxell:masterfrom
Script47 wants to merge 2 commits intoircmaxell:masterfrom
Conversation
Fixed the sentence structure to make it easier to read.
GrahamCampbell
suggested changes
Sep 7, 2017
| This will use the strongest algorithm available to PHP at the current time. Presently, this is the same as specifying `PASSWORD_BCRYPT`. But in future versions of PHP, it may be updated to use a stronger algorithm if one is introduced. It can also be changed if a problem is identified with the BCRYPT algorithm. Note that if you use this option, you are **strongly** encouraged to store it in a `VARCHAR(255)` column to avoid truncation issues if a future algorithm increases the length of the generated hash. | ||
|
|
||
| It is very important that you should check the return value of `password_hash` prior to storing it, because `false` or `null` may be returned if it encountered an error. | ||
| It is very important that you check the return value of `password_hash` prior to storing it, because `false` or `null` may be returned if it encounters any errors. |
Contributor
There was a problem hiding this comment.
if it encountered an error - the original text was already correct
Author
|
Definitely not, read how hard it is to say the original sentence: It is very important that you should check the return value of You could possibly get away with the end change that I made but the should should not be be there. Compared to the sentence I proposed: It is very important that you check the return value of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the sentence structure to make it easier to read.