-
Notifications
You must be signed in to change notification settings - Fork 2
Spanish translation completed #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
konecnyjakub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for translating the campaign @Sebas38760, I appreciate it. I cannot check whether texts are translated correctly (as my knowledge of Spanish is almost non-existing) but given your previous works, I assume that it is correct. However there are still a few issues, see bellow.
The translation in _server.pbl does not seem to do anything. When I connect to the add-ons server (with language set to Spanish) and select the add-on, the title and description are still in English and there are no errors in log. The Czech translation works just fine. I have not found the cause yet, I will look into it again later (unless you are able to fix it before me).
The .po file seems to contain 8 strings that are not in the .pot file and misses 8 strings that are there. Please, check this.
The .mo file is not necessary, just the .po file is fine (for add-ons). If the add-on has only the .po file, it should be named differently and placed in a different folder (in this case es.po in translations/wesnoth-For_Power). But I can change that myself after merging this pr.
konecnyjakub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to be in order with the .po file now, good job. The translation in _server.pbl is still not working for me but I can try to figure out why later. So I will merge this as is. Thank you again @Sebas38760.
I will put you into credits for the translation. How do you want to be listed? Sebas38760? Sebastián Lecchini? Sebastián Lecchini (Sebas38760)? Something else?
|
Thank you. Regarding server.pbl, I experienced the same issue when updating GambCiv for 1.19. It seems that the changes are not visible until the update is actually published. To test it, I had to create an empty add-on, place the server.pbl file inside it, and then test it that way. |


-Translation for server.pbl
-Added the es/LC_MESSAGES directory
-Added Spanish translations in .po and .mo format