Skip to content

Conversation

@Sebas38760
Copy link

-Translation for server.pbl

-Added the es/LC_MESSAGES directory

-Added Spanish translations in .po and .mo format

@Sebas38760 Sebas38760 requested review from a team as code owners December 26, 2025 16:20
Copy link
Member

@konecnyjakub konecnyjakub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for translating the campaign @Sebas38760, I appreciate it. I cannot check whether texts are translated correctly (as my knowledge of Spanish is almost non-existing) but given your previous works, I assume that it is correct. However there are still a few issues, see bellow.

The translation in _server.pbl does not seem to do anything. When I connect to the add-ons server (with language set to Spanish) and select the add-on, the title and description are still in English and there are no errors in log. The Czech translation works just fine. I have not found the cause yet, I will look into it again later (unless you are able to fix it before me).

The .po file seems to contain 8 strings that are not in the .pot file and misses 8 strings that are there. Please, check this.

The .mo file is not necessary, just the .po file is fine (for add-ons). If the add-on has only the .po file, it should be named differently and placed in a different folder (in this case es.po in translations/wesnoth-For_Power). But I can change that myself after merging this pr.

Copy link
Member

@konecnyjakub konecnyjakub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be in order with the .po file now, good job. The translation in _server.pbl is still not working for me but I can try to figure out why later. So I will merge this as is. Thank you again @Sebas38760.

I will put you into credits for the translation. How do you want to be listed? Sebas38760? Sebastián Lecchini? Sebastián Lecchini (Sebas38760)? Something else?

@Sebas38760
Copy link
Author

Thank you.
Please list me as Sebastián Lecchini (Sebas38760).

Regarding server.pbl, I experienced the same issue when updating GambCiv for 1.19. It seems that the changes are not visible until the update is actually published. To test it, I had to create an empty add-on, place the server.pbl file inside it, and then test it that way.

In server addons 1.18
Screenshot_20251226_184345_The Battle for Wesnoth

In 1.19
Screenshot_20251226_184545_The Battle for Wesnoth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants