Open
Conversation
Fuminiton
reviewed
Apr 11, 2025
| for (int i = 0; i < nums.size(); i++) { | ||
| auto complement = k + cumulative_sum[i]; | ||
| auto* indexes = &cumulative_sum_to_indexes[complement]; | ||
| num_subarrays_with_sum_k += (*indexes).end() - std::upper_bound((*indexes).begin(), (*indexes).end(), i); |
There was a problem hiding this comment.
ご存じかもしれませんが、
1行の長さに関しても、Google C++ Style Guideに記載があります。
https://google.github.io/styleguide/cppguide.html#Line_Length
80 characters is the maximum.
A line may exceed 80 characters if it is
| } | ||
| }; | ||
| ``` | ||
|
|
oda
reviewed
Apr 13, 2025
| for (int i = 0; i < nums.size(); i++) { | ||
| auto complement = k + cumulative_sum[i]; | ||
| auto* indexes = &cumulative_sum_to_indexes[complement]; | ||
| num_subarrays_with_sum_k += (*indexes).end() - std::upper_bound((*indexes).begin(), (*indexes).end(), i); |
There was a problem hiding this comment.
(*indexes).end() は、たぶん indexes->end() が使えますかね?
| class Solution { | ||
| public: | ||
| int subarraySum(const std::vector<int>& nums, int k) { | ||
| std::map<int, std::vector<int>> cumulative_sum_to_indexes; |
There was a problem hiding this comment.
map<int, deque<int>> にしたら、頭から i 以下のものを削除していくだけでいったりしますかね。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Problem
Subarray Sum Equals K
Next Problem
Number of Islands