-
Notifications
You must be signed in to change notification settings - Fork 102
update: upgrade sheet tabs interactions #564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the dialog-based sheet renaming workflow with inline editing and adds right-click menu support, improving the user experience to match common spreadsheet applications.
Key Changes:
- Right-click on sheet tabs now opens the options menu directly
- Double-clicking sheet tabs enables inline name editing
- Removed the separate rename dialog component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| SheetTabBar.tsx | Added height: 100% to the Sheets container for proper layout |
| SheetTab.tsx | Implemented inline editing with input field, context menu support via right-click, updated styling for active states, and keyboard handling (Enter/Escape) |
| SheetRenameDialog.tsx | Removed dialog component as it's replaced by inline editing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nhatcher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR introduces two quality-of-life improvements to the sheet tab buttons, making them more intuitive and aligned with typical spreadsheet behavior.
1. Right-click opens the options menu
Users can now open the sheet options menu using right-click, same way as in most spreadsheet applications.
2. Sheet names can be edited inline
Double-clicking a sheet tab now turns it into an inline text input, allowing users to rename the sheet directly.
Previously, renaming required a separate dialog, which interrupted workflow.
Additionally, selecting “Rename sheet” from the menu now automatically focuses the input.
Testing
Entersaves the new sheet name; pressingEscapecancels it.