Skip to content

Conversation

@dg-ac
Copy link
Contributor

@dg-ac dg-ac commented Nov 19, 2025

This PR introduces two quality-of-life improvements to the sheet tab buttons, making them more intuitive and aligned with typical spreadsheet behavior.


1. Right-click opens the options menu

Users can now open the sheet options menu using right-click, same way as in most spreadsheet applications.

image

2. Sheet names can be edited inline

Double-clicking a sheet tab now turns it into an inline text input, allowing users to rename the sheet directly.
Previously, renaming required a separate dialog, which interrupted workflow.

Additionally, selecting “Rename sheet” from the menu now automatically focuses the input.

image

Testing

  • Right-click on a sheet tab opens the correct options menu.
  • Double-clicking a sheet tab enables inline name editing.
  • Pressing Enter saves the new sheet name; pressing Escape cancels it.
  • Choosing Rename sheet from the menu focuses the inline input.
  • Verify behavior on multiple sheets, including pinned/renamed ones.
  • Confirm proper behavior on desktop and mobile.

@nhatcher nhatcher requested a review from Copilot November 19, 2025 04:29
@nhatcher nhatcher self-assigned this Nov 19, 2025
Copilot finished reviewing on behalf of nhatcher November 19, 2025 04:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the dialog-based sheet renaming workflow with inline editing and adds right-click menu support, improving the user experience to match common spreadsheet applications.

Key Changes:

  • Right-click on sheet tabs now opens the options menu directly
  • Double-clicking sheet tabs enables inline name editing
  • Removed the separate rename dialog component

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
SheetTabBar.tsx Added height: 100% to the Sheets container for proper layout
SheetTab.tsx Implemented inline editing with input field, context menu support via right-click, updated styling for active states, and keyboard handling (Enter/Escape)
SheetRenameDialog.tsx Removed dialog component as it's replaced by inline editing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@nhatcher nhatcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nhatcher nhatcher merged commit cc01556 into main Nov 23, 2025
1 check passed
@nhatcher nhatcher deleted the dani/widget/tabs branch November 23, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants